Running on windows support

detox/.eslintrc

@@ -400,5 +400,13 @@
     "promise/no-promise-in-callback": "error",
     "promise/no-callback-in-promise": "off",
     "promise/avoid-new": "off"
-  }
+  },
+  "overrides": [
+    {
+      "files": "scripts/**",
+      "rules": {
+        "no-console": "off"
+      }
+    }
+  ]
 }

detox/local-cli/detox-run-server.js

@@ -2,14 +2,11 @@
 
 const program = require('commander');
 const cp = require('child_process');
-const fs = require('fs');
 const path = require('path');
 
 program.parse(process.argv);
 
-if (fs.existsSync(path.join(process.cwd(), 'node_modules/.bin/detox-server'))) {
-  cp.execSync('node_modules/.bin/detox-server', {stdio: 'inherit'});
-} else {
-  cp.execSync('node_modules/detox/node_modules/.bin/detox-server', {stdio: 'inherit'});
-}
-
+const serverPackagePath = require.resolve('detox-server/package.json');
+const cli = require(serverPackagePath).bin['detox-server'];
+const binPath = path.join(path.dirname(serverPackagePath), cli);
+cp.execFileSync('node', [binPath], {stdio: 'inherit'});

detox/local-cli/detox-test.js

@@ -74,7 +74,8 @@ function runMocha() {
   const platform = program.platform ? `--grep ${getPlatformSpecificString(program.platform)} --invert` : '';
 
   const debugSynchronization = program.debugSynchronization ? `--debug-synchronization ${program.debugSynchronization}` : '';
-  const command = `node_modules/.bin/mocha ${testFolder} ${configFile} ${configuration} ${loglevel} ${cleanup} ${reuse} ${debugSynchronization} ${platform} ${artifactsLocation}`;
+  const binPath = path.join('node_modules', '.bin', 'mocha');
+  const command = `${binPath} ${testFolder} ${configFile} ${configuration} ${loglevel} ${cleanup} ${reuse} ${debugSynchronization} ${platform} ${artifactsLocation}`;
 
   console.log(command);
   cp.execSync(command, {stdio: 'inherit'});
@@ -83,7 +84,8 @@ function runMocha() {
 function runJest() {
   const configFile = runnerConfig ? `--config=${runnerConfig}` : '';
   const platform = program.platform ? `--testNamePattern='^((?!${getPlatformSpecificString(program.platform)}).)*$'` : '';
-  const command = `node_modules/.bin/jest ${testFolder} ${configFile} --runInBand ${platform}`;
+  const binPath = path.join('node_modules', '.bin', 'jest');
+  const command = `${binPath} ${testFolder} ${configFile} --runInBand ${platform}`;
   console.log(command);
   cp.execSync(command, {
     stdio: 'inherit',

detox/package.json

@@ -21,13 +21,13 @@
   "author": "Tal Kol <talkol@gmail.com>",
   "license": "MIT",
   "scripts": {
-    "build": "scripts/build.sh",
-    "lint": "eslint src",
+    "build": "node scripts/build.js",
+    "lint": "eslint src scripts",
     "unit": "jest --coverage --verbose",
     "test": "npm run unit",
     "unit:watch": "jest --watch",
     "prepublish": "npm run build",
-    "postinstall": "scripts/postinstall.sh"
+    "postinstall": "node scripts/postinstall.js"
   },
   "devDependencies": {
     "eslint": "^4.11.0",

detox/scripts/build.js

@@ -0,0 +1,30 @@
+#!/usr/bin/env node
+
+// Javascript for windows support.
+
+if (process.argv[2] === "android" || process.argv[3] === "android") {
+	console.log("\nBuilding Detox aars");
+	const aars = [
+		"detox-minReactNative44-debug.aar",
+		"detox-minReactNative46-debug.aar",
+		"detox-minReactNative44-release.aar",
+		"detox-minReactNative46-release.aar"
+	];
+	aars.forEach(aar => {
+		fs.removeSync(aar);
+	});
+
+	childProcess.execFileSync(
+		"android/gradlew",
+		["assembleDebug", "assembleRelease"],
+		{
+			cwd: "android",
+			stdio: "inherit",
+			shell: true
+		}
+	);
+
+	aars.forEach(aar => {
+		fs.copySync(`android/detox/build/outputs/aar/${aar}`, aar);
+	});
+}

detox/scripts/postinstall.js

@@ -0,0 +1,8 @@
+#!/usr/bin/env node
+
+// Javascript for windows support.
+if (process.platform === "darwin") {
+	require("child_process").execSync(`${__dirname}/build_framework.ios.sh`, {
+		stdio: "inherit"
+	});
+}

detox/src/devices/EmulatorDriver.js

@@ -52,10 +52,17 @@ class EmulatorDriver extends AndroidDriver {
     }
 
     await this._fixEmulatorConfigIniSkinName(name);
-    await this.emulator.boot(name);
 
-    const adbDevices = await this.adb.devices();
-    const filteredDevices = _.filter(adbDevices, {type: 'emulator', name: name});
+    let adbDevices = await this.adb.devices();
+    let filteredDevices = _.filter(adbDevices, {type: 'emulator', name: name});
+
+    // If it's not already running, start it now.
+    if (!filteredDevices.length) {
+      await this.emulator.boot(name);
+    }
+
+    adbDevices = await this.adb.devices();
+    filteredDevices = _.filter(adbDevices, {type: 'emulator', name: name});
 
     let adbName;
     switch (filteredDevices.length) {

detox/src/utils/exec.js

@@ -47,6 +47,16 @@ async function execWithRetriesAndLogs(bin, options, statusLogs, retries = 10, in
   //  log.error(`${_operationCounter}: stderr:`, result.stderr);
   //}
 
+  /* istanbul ignore next */
+  if (process.platform === 'win32') {
+    if (result.stdout) {
+      result.stdout = result.stdout.replace(/\r\n/g, '\n');
+    }
+    if (result.stderr) {
+      result.stderr = result.stderr.replace(/\r\n/g, '\n');
+    }
+  }
+
   return result;
 }