Avoid NPE when DetoxServerUrl and DetoxSessionId are not set #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid NPE when DetoxServerUrl and DetoxSessionId are undefined
rotemmiz
approved these changes
Apr 14, 2018
wiyarmir
added a commit
to Skyscanner/detox
that referenced
this pull request
Apr 20, 2018
Avoid NPE when DetoxServerUrl and DetoxSessionId are undefined (cherry picked from commit 9ee1723)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the JavaDocs of Detox.java, "If not set, then Detox tests are no ops. So it's safe to mix it with other tests."
However, this is not true, since the code will throw a NullPointerException and crash the tests. A simple nullcheck will avoid it.
As a side recommendation, the usage of nullability annotations helps catching this issues. Please consider adding them to the project. I am happy to do so if deemed acceptable.