[+coverage] unit tests for ArtifactsManager.js and ArtifactPlugin.js #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noomorph
force-pushed
the
noomorph/unit-tests-for-abstract-plugin-classes
branch
from
24b2058 to
b62e9bf
Compare
noomorph
force-pushed
the
noomorph/unit-tests-for-abstract-plugin-classes
branch
from
b62e9bf to
d00ef63
Compare
rotemmiz
requested changes
Jul 2, 2018
| @@ -7,7 +9,7 @@ describe('buildDefaultArtifactsRootDirpath', () => { | |||
| }); | |||
|
|
|||
| it('should append subdir if dir does not end with /', () => { | |||
| expect(buildDefaultArtifactsRootDirpath('iphone8', 'artifacts')).toBe('artifacts/iphone8.Today 1:23:45PM'); | |||
| expect(buildDefaultArtifactsRootDirpath('iphone8', 'artifacts')).toBe(path.join('artifacts', 'iphone8.Today 1:23:45PM')); | |||
There was a problem hiding this comment.
paths/files can not include the character : or any punctuation mark for that matter.
There was a problem hiding this comment.
Why not? It is escaped by Node.js so OS feels OK about this. Works on Win32, Linux and Mac without any problem.
rotemmiz
approved these changes
Jul 2, 2018
25 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thisin.untrackArtifact()method in ArtifactsManageronBeforeRelaunchAppevent in test artifactartifacts/ArtifactsManager.jsartifacts/templates/plugin/ArtifactPlugin.jsartifacts/templates/plugin/TwoSnapshotsPerTestPlugin.jsartifacts/templates/plugin/WholeTestRecorderPlugin.jsartifacts/templates/plugin/StartupAndTestRecorderPlugin.test.jsdetox/src/artifacts/utils/buildDefaultArtifactsRootDirpath.test.jsdetox/src/artifacts/utils/ArtifactPathBuilder.test.js