Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #831 #839

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Resolves #831 #839

merged 2 commits into from
Jul 19, 2018

Conversation

noomorph
Copy link
Collaborator

Changes ADB.pidof() helper method implementation to the most backward-compatible way: ps | grep.
Tested on API 19, 21, 28.

@noomorph noomorph requested a review from rotemmiz as a code owner July 18, 2018 12:58
@rotemmiz rotemmiz merged commit ac4ea8d into master Jul 19, 2018
@noomorph noomorph deleted the noomorph/issue-831 branch July 19, 2018 11:40
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rotemmiz rotemmiz rotemmiz approved these changes

Assignees
No one assigned
Labels
domain: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noomorph @rotemmiz