Prevent retaining button component in componentRegistry (#4888)

wix · Mar 20, 2019 · 0186b1a · 0186b1a
1 parent 5ba7ccb
commit 0186b1a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/ios/RNNReactComponentRegistry.m b/lib/ios/RNNReactComponentRegistry.m
@@ -2,7 +2,7 @@
 
 @interface RNNReactComponentRegistry () {
 	id<RNNRootViewCreator> _creator;
-	NSMutableDictionary* _componentStore;
+	NSMapTable* _componentStore;
 }
 
 @end
@@ -12,7 +12,7 @@ @implementation RNNReactComponentRegistry
 - (instancetype)initWithCreator:(id<RNNRootViewCreator>)creator {
 	self = [super init];
 	_creator = creator;
-	_componentStore = [NSMutableDictionary new];
+	_componentStore = [NSMapTable strongToWeakObjectsMapTable];
 	return self;
 }
 
@@ -31,7 +31,7 @@ - (RNNReactView *)createComponentIfNotExists:(RNNComponentOptions *)component pa
 }
 
 - (NSMutableDictionary *)componentsForParentId:(NSString *)parentComponentId {
-	if (!_componentStore[parentComponentId]) {
+	if (![_componentStore objectForKey:parentComponentId]) {
 		[_componentStore setObject:[NSMutableDictionary new] forKey:parentComponentId];;
 	}