Fix modalpresentationstyle (#6077)

* Fix invalid popover enum value for modal presentation style The correct enum value as defined in lib/ios/RNNConvert.m is "popover" not "popOver", in line with UIModalPresentationPopover. * Add to documentation on modal presentation styles Add popover value and link to iOS documentation. Co-authored-by: Yogev Ben David <yogev132@gmail.com>
wix · Mar 31, 2020 · 951a07b · 951a07b
1 parent 287d23a
commit 951a07b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/docs/api/OptionsModalPresentationStyle.md b/docs/api/OptionsModalPresentationStyle.md
@@ -7,4 +7,4 @@
 - overCurrentContext
 - overFullScreen
 - pageSheet
-- popOver
+- popover
diff --git a/docs/docs/options-migration.md b/docs/docs/options-migration.md
@@ -374,11 +374,14 @@ topBar: {
 Controls the behavior of screens displayed modally. 
 
 ### Options supported on iOS
-* overCurrentContext - Content is displayed over the previous screen. Useful for **transparent modals**
+* `overCurrentContext` - Content is displayed over the previous screen. Useful for **transparent modals**
 * `formSheet` - Content is centered in the screen
 * `pageSheet` -Content partially covers the underlying content
 * `overFullScreen` - Content covers the screen, without detaching previous content.
 * `fullScreen` - Content covers the screen, previous content is detached.
+* `popover` - Content is displayed in a popover view.
+
+More information on the different styles for iOS can be found on https://developer.apple.com/documentation/uikit/uimodalpresentationstyle
 
 ### Options supported on Android
 * `overCurrentContext` - Content is displayed over the previous screen. Useful for **transparent modals**

diff --git a/lib/src/interfaces/Options.ts b/lib/src/interfaces/Options.ts
@@ -119,7 +119,7 @@ export enum OptionsModalPresentationStyle {
   overFullScreen = 'overFullScreen',
   overCurrentContext = 'overCurrentContext',
   currentContext = 'currentContext',
-  popOver = 'popOver',
+  popover = 'popover',
   fullScreen = 'fullScreen',
   none = 'none'
 }