[Docs] Installation Instructions | Fix nested list numbering #5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current numbering causes the line ```In Xcode, you will need to edit this file: AppDelegate.m. This function is the main entry point for your app:``` to appear as instruction 1, not 3.
JacobJaffe
changed the title
JacobJaffe
changed the title
|
Thanks a lot @JacobJaffe ! |
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
Current numbering causes the line ```In Xcode, you will need to edit this file: AppDelegate.m. This function is the main entry point for your app:``` to appear as instruction 1, not 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current numbering causes the line
In Xcode, you will need to edit this file: AppDelegate.m. This function is the main entry point for your app:to appear as instruction 1, not 3.
(And some other indentation weirdness on the docs)
I'm unsure how to test the build changes on the website (The changes make the markdown render correctly in places like Github's view though) -- is there a documented process for this?
I encountered this issue while attempting to set up a new project with RNN V2 -- I ran into very similar issues as #4610 -- I think that the current docs have mislead folks into thinking that step 3 for iOS installation is only necessary if there is an error (I know this is what happened to me at least 😄 ).