Fix overlay touch detection #6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogevbd
approved these changes
Jul 8, 2020
|
🚀 |
|
has this been regressed? I am now seeing this again in my app :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Overlay was displayed with
statusBar.drawBehind: false, the StatusBar height wasn't accounted for when calculating if touch events were inside the view's bounds.To begin with, StatusBar height had to be accounted for because we used
MotionEvent.rawYcoordinates instead ofMotionEvent.ycoordinate which already take into account the view's position within the hierarchy, which compensates for StatusBar height.fixes #5976