Expose the multicast property of RNNotifications so it can be used for tweaks #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When you look at this repo you see only a few open PR's and only a few open issues. It makes you assume it's an active project, when in fact, it's just stalebot closing stuff. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This is not stale!!!!!!!!! |
|
@erkie , please rebase and see if tests are passing. Thanks! |
|
Seems to fail on Not anything related to my changes AFAICS. Do you think it's related to my changes? |
|
@erkie you can see the error in the last build: |
|
I think that fixed it, looks like the failing issue is that this PR is missing a label now? |
|
Thanks to you too! |
|
will be release with #756 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to customize the handling of the notifications for iOS. The only way to do this was to implement a wrapper around the
RNNotificationCenterMulticastinstance. This PR exposes that as an interface method on theRNNotificationsobject.