Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel and channel group implementation #750

Merged
merged 5 commits into from
Jun 23, 2021

Conversation

DanielEliraz
Copy link
Collaborator

@DanielEliraz DanielEliraz commented Jun 22, 2021

#535 started implementing custom channel and channels group creation but there were some missing parts that this PR finishes:

  • Using the incoming channel in PostNotification after creating it
  • Add channel group name and add this group to the custom channel
  • Show it in the example app

This PR also fixes very old tests
Closes #723

@yogevbd yogevbd merged commit f5b25b5 into master Jun 23, 2021
@yogevbd yogevbd deleted the fix-channnel-and-channel-group-implementation branch June 23, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sound not playing
2 participants