Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Migrate to RN68 #2041

Merged
merged 7 commits into from
Jul 7, 2022
Merged

WIP - Migrate to RN68 #2041

merged 7 commits into from
Jul 7, 2022

Conversation

ethanshar
Copy link
Collaborator

@ethanshar ethanshar commented May 10, 2022

Description

This is still a WIP

Working with this upgrade tool
https://react-native-community.github.io/upgrade-helper/?from=0.66.4&to=0.68.2

I'm currently on the android/app/src/main/java/com/rndiffapp/MainActivity.java file
We need to figure to handle this file migration regarding RNN, see this issue
wix/react-native-navigation#7466

Changelog

Upgrade to RN68

@M-i-k-e-l
Copy link
Contributor

M-i-k-e-l commented Jun 16, 2022

Both platforms are running but I did not test anything specific.
I hope the change in styles.xml for Android will not cause a problem with dark mode:

<item name="android:editTextBackground">@drawable/rn_edit_text_material</item>

@ethanshar ethanshar self-assigned this Jun 21, 2022
ios/Podfile Outdated Show resolved Hide resolved
@ethanshar
Copy link
Collaborator Author

@M-i-k-e-l
I can't approve this PR, cause I created it.
So you can approve and merge (:

@M-i-k-e-l M-i-k-e-l marked this pull request as ready for review July 7, 2022 08:10
@M-i-k-e-l M-i-k-e-l merged commit 3f5a917 into master Jul 7, 2022
@M-i-k-e-l M-i-k-e-l deleted the infra/RN68 branch July 7, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants