Add segmentStyle prop to SegmentedControl #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Apr 18, 2023
Inbal-Tish
reviewed
Apr 18, 2023
| @@ -164,6 +169,7 @@ const SegmentedControl = (props: SegmentedControlProps) => { | |||
| selectedIndex={animatedSelectedIndex} | |||
| activeColor={activeColor} | |||
| inactiveColor={inactiveColor} | |||
| segmentStyle={segmentStyle} | |||
There was a problem hiding this comment.
If it's an individual style for each segment, why it's not passed in the segment, meaning part of the SegmentedControlItemProps and not the SegmentedControlProps? It's confusing, or maybe it's just the naming...
There was a problem hiding this comment.
Maybe it is confusing because I actually wanted one style prop for all of them. 😅
Maybe segmentsStyle in plural?
There was a problem hiding this comment.
Yes, I guess segmentsStyle is better...
Inbal-Tish
reviewed
Apr 19, 2023
| @@ -98,6 +102,7 @@ const SegmentedControl = (props: SegmentedControlProps) => { | |||
| outlineColor = activeColor, | |||
| outlineWidth = BORDER_WIDTH, | |||
| throttleTime = 0, | |||
| segmentsStyle: segmentsStyleProp, | |||
There was a problem hiding this comment.
Why do you need the rename here?
There was a problem hiding this comment.
There's another segmentsStyle in this file
Inbal-Tish
approved these changes
Apr 19, 2023
lidord-wix
added a commit
that referenced
this pull request
May 15, 2023
* Add segmentStyle prop to SegmentedControl * renaming * renaming #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SegmentedControl - add segmentStyle prop (and update example)
#2495
Changelog
SegmentedControl - add segmentStyle prop