fix(core): remove pure markers from js module output #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoros
added
core
barak007
approved these changes
Jan 12, 2024
idoros
added a commit
that referenced
this pull request
Feb 1, 2024
* test(webpack): check js module tree-shake * test(rollup): check js module tree-shake * test(esbuild): check js module tree-shake * chore: remove unneeded pure functions markers from generated js module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed the /#PURE/ annotations from the JavaScript module output. The reason for this removal is that these markers appear to trigger errors with
vite@5:Although we currently do not conduct tests on vite (at all), this pull request introduces new tests. These tests are designed to verify the effectiveness of tree-shaking for different build tools, including
webpack,rollup, andesbuild. The goal is to ensure that the removal of these markers does not adversely impact the final output.The annotations have been completely removed as it appears they no longer influence tree-shaking. This could be due to improvements in the tree-shaking algorithm over time or because the module output has been simplified to the extent that these annotations are now redundant.
Note: this should be merged to
stylable@5first and then cherry-picked to master