Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive Clang 8 support #722

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Revive Clang 8 support #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,9 @@ jobs:
- cc: gcc-9
cxx: g++-9
apt: gcc-9
#- cc: clang-7
# cxx: clang++-7
# apt: clang-7
#- cc: clang-8
# cxx: clang++-8
# apt: clang-8
- cc: clang-8
cxx: clang++-8
apt: clang-8
- cc: clang-9
cxx: clang++-9
apt: clang-9
Expand Down
2 changes: 1 addition & 1 deletion docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ nanobinds depends on
- **Python 3.8+** or **PyPy 7.3.10+** (the *3.8* and *3.9* PyPy flavors are
supported, though there are :ref:`some limitations <pypy_issues>`).
- **CMake 3.15+**.
- **A C++17 compiler**: Clang 7+, GCC 8+, MSVC2019+, and the CUDA NVCC compiler
- **A C++17 compiler**: Clang 8+, GCC 8+, MSVC2019+, and the CUDA NVCC compiler
are officially supported. Others (MinGW, Cygwin, Intel, ..) may work as well
but will not receive support.

Expand Down
4 changes: 2 additions & 2 deletions include/nanobind/nb_tuple.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ template <typename T, typename... Ts> struct tuple<T, Ts...> : tuple<Ts...> {

tuple() = default;
tuple(const tuple &) = default;
tuple(tuple &&) noexcept = default;
tuple& operator=(tuple &&) noexcept = default;
tuple(tuple &&) = default;
tuple& operator=(tuple &&) = default;
tuple& operator=(const tuple &) = default;

template <typename A, typename... As>
Expand Down