Improve logging for meta refresh quote error

Will fix #137
wjdp · Jan 16, 2021 · 32ed5f8 · 32ed5f8
1 parent bbdd205
commit 32ed5f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/htmltest/check-meta.go b/htmltest/check-meta.go
@@ -32,13 +32,12 @@ func (hT *HTMLTest) checkMetaRefresh(document *htmldoc.Document, node *html.Node
 		if len(contentSplit) == 2 {
 			if contentSplit[1][0] == 34 || contentSplit[1][0] == 39 {
 				hT.issueStore.AddIssue(issues.Issue{
-					Level:     issues.LevelError,
-					Message:   "url in meta refresh must not start with single or double quote",
-					Reference: ref,
+					Level:    issues.LevelError,
+					Message:  "url in meta refresh must not start with single or double quote",
+					Document: document,
 				})
 				return
 			}
-
 			ref, err = htmldoc.NewReference(document, node, contentSplit[1])
 		} else {
 			ref, err = htmldoc.NewReference(document, node, "")

diff --git a/htmltest/check-meta_test.go b/htmltest/check-meta_test.go
@@ -88,5 +88,5 @@ func TestMetaRefreshContentInvalid(t *testing.T) {
 func TestIssue92(t *testing.T) {
 	hT := tTestFile("fixtures/meta/issues/92.html")
 	tExpectIssueCount(t, hT, 2)
-	tExpectIssue(t, hT, "url in meta refresh must not start with single or double quote", 2)
+	tExpectIssue(t, hT, "url in meta refresh must not start with single or double quote", 3)
 }