Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable python -m gdown <URL> by renaming cli.py to __main__.py #306

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

wkentaro
Copy link
Owner

@wkentaro wkentaro commented Jan 28, 2024

So that we can do:

python -m gdown <url>

@wkentaro wkentaro self-assigned this Jan 28, 2024
@wkentaro wkentaro added enhancement for pr feature for pr and removed enhancement for pr labels Jan 28, 2024
@wkentaro wkentaro changed the title Rename cli.py -> __main__.py Enable python -m gdown <URL> by renaming cli.py to __main__.py Jan 28, 2024
@wkentaro wkentaro merged commit 79d82aa into main Jan 28, 2024
2 checks passed
@wkentaro wkentaro deleted the rename_cli_py______main___py branch January 28, 2024 01:48
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 3, 2024

did you intend to remove the feature gdown --help? do you want users to use python -m gdown always?

@wkentaro
Copy link
Owner Author

wkentaro commented Feb 4, 2024

no, gdown command should work. it's not working?

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 4, 2024

You are right. It still works. Sorry for the noise

@wkentaro
Copy link
Owner Author

wkentaro commented Feb 5, 2024

No problem. Thanks for double checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature for pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants