Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: preserve GDrive's last modified time when downloading #351

Merged
merged 2 commits into from
May 12, 2024

Conversation

moulins
Copy link
Contributor

@moulins moulins commented May 2, 2024

When downloading to the filesystem, retrieve the Last-Modified date from the HTTP headers and use it to set the on-disk mtime of the downloaded file.

I've implemented this unconditionally, but maybe this should be gated behind a --mtimes CLI (and python API) option?

@wkentaro wkentaro self-assigned this May 12, 2024
@wkentaro wkentaro added the feature for pr label May 12, 2024
@wkentaro
Copy link
Owner

This makes sense. Thanks!

@wkentaro wkentaro merged commit 530c015 into wkentaro:main May 12, 2024
3 checks passed
@moulins moulins deleted the local-mtime branch May 12, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature for pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants