Use buffer instead of sliding buffer and remove LinkedList #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #59. Basically, the use of LinkedList is not supported in babashka.
New Implementation
I switched to using a buffer instead of a sliding buffer, so now the buffer will not discard previous input, with the caveat that the streaming will be blocked when there's nothing on the other side of the channel taking streaming response out of the buffer (which I think is reasonable, if the consumer side cannot process fast enough then maybe they need to reconsider rather than just pile everything inside JVM heap). I also picked a arbitrarily large buffer size.