Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows fix #17

Closed
wants to merge 13 commits into from
Closed

Windows fix #17

wants to merge 13 commits into from

Conversation

wkpark
Copy link
Owner

@wkpark wkpark commented Oct 15, 2024

Done

  • rebased on the latest triton
  • remove needless patches, minimize win32 specific patches
  • AMD rocm fixes

TODO

  • separate MSVC related hunks
  • rework build workflows

wkpark added 13 commits October 13, 2024 21:48
 * based on triton-lang#2465
 * manually applied, rebased, fix lint errors
 * use set_target_properties(), cleanup for windows
 * remove '/A' platform option to use windows ninja
 * remove unknown option '/m'
 * use sysconfig.get_config_var() to get the path of python*.lib
 * clang fix for windows
 * remove '-fPIC' for windows clang
 * fix download_and_copy() to support windows
 * add "exe" extension for windows
 * use "pyd" extension for windows to make importlib work
 * rework for latest triton (2024/01/14)

Original-author-by: Andrei Gheorghe <andrei@dharmaventures.co>
Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
 * based on Windows support PR triton-lang#2456 by @andreigh
 * WIN32 fix using LoadLibrary
 * win32 fix _path_to_binary()
 * add library_dir, include_dir for win32
This reverts commit 52152a7.
@wkpark wkpark force-pushed the main branch 4 times, most recently from 3a62602 to 2cd6cce Compare October 18, 2024 03:19
@wkpark wkpark closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant