forked from tektoncd/pipeline
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This was something previously brought up in tektoncd#1607, but was deferred to allow for continued discussion. Pros of making this change: * Reduces size of incoming PRs when new dependencies are used. * Removes confusion around source of truth for dependencies (e.g. vendor vs mod). This was an issue that tektoncd#1763 solved by pinning to vendor, this will solve the same problem differently by always deferring to the version in go.mod. * Allows easier use of upstream and dependent types without the use of vendor - see https://gist.github.com/wlynch/325293bc3fbc488d3b3d319f3a93bbea for an example of why this is difficult today. Risks of making this change: * Dependencies will not be present in initial clone. They will be fetched dynamicly when needed, which may cause workflow distruptions. * This breaks compatibility with older versions of Go (though for certain projects like triggers, we already require Go >= 1.13). Third-party obligations (for things like making source available in images) have already been addressed in tektoncd#1607. As with tektoncd#1607, this change is more easily viewed by running `git diff master -- ':!third_party' ':!vendor'`
- Loading branch information
Showing
3,884 changed files
with
5 additions
and
1,148,043 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.