Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run coverage generation as part of the test command #535

Closed
wants to merge 1 commit into from

Conversation

JeroenDeDauw
Copy link
Contributor

This is to detect incorrect @Covers tags before the code gets to ScutinizerCI. We are already doing this at https://github.com/wmde/WikibaseDataModelServices/blob/master/composer.json

A better approach would be nice though, considering this slows down the execution of the test command by doing a lot of not needed work. Apparently this is not going to come from the PHPUnit side though, as per sebastianbergmann/phpunit#1760

This is to detect incorrect @Covers tags before the code gets to ScutinizerCI. We are already doing this at https://github.com/wmde/WikibaseDataModelServices/blob/master/composer.json

A better approach would be nice though, considering this slows down the execution of the test command by doing a lot of not needed work. Apparently this is not going to come from the PHPUnit side though, as per sebastianbergmann/phpunit#1760
@thiemowmde
Copy link
Contributor

-2, sorry. The slowdown on my machine is significant, Instead of ~700 ms it takes 7 seconds.

@JeroenDeDauw
Copy link
Contributor Author

Is 7 second thats unreasonable for the things you need to run before pushing a commit? (If so, how can you stand working on Wikibase.git?) You can still run the PHPUnit tests themselves while coding.

@thiemowmde
Copy link
Contributor

I can barely "stand working on Wikibase.git". I do not run the repo, client and lib tests on my machine on a regular basis. Usually I run only the single test I'm touching and then count on Jenkins to complain if I broke something. I do not like this situation. Over the past months I spend several hours benchmarking the Wikibase.git tests and already found and fixed some bottlenecks.

@addshore
Copy link
Contributor

addshore commented Sep 2, 2015

I can barely "stand working on Wikibase.git"

Maybe we should split it into the 3 repos it belongs in ? ;)

@JeroenDeDauw JeroenDeDauw deleted the detect-covers-fails branch November 4, 2015 22:17
@JeroenDeDauw JeroenDeDauw restored the detect-covers-fails branch November 5, 2015 17:29
@JeroenDeDauw JeroenDeDauw reopened this Nov 5, 2015
@JeroenDeDauw
Copy link
Contributor Author

Alternative provided by #572

@JeroenDeDauw JeroenDeDauw mentioned this pull request Nov 5, 2015
@JeroenDeDauw JeroenDeDauw deleted the detect-covers-fails branch December 6, 2015 03:49
@thiemowmde
Copy link
Contributor

  • phpunit: 0m1.195s
  • phpunit --coverage-text=/dev/null: 0m8.521s
  • phpunit --coverage-php /dev/null: 0m6.983s

@thiemowmde thiemowmde restored the detect-covers-fails branch January 11, 2016 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants