Add TermTypes interface with term type constants #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladsgroup
approved these changes
Jan 30, 2020
Ladsgroup
reviewed
Jan 30, 2020
|
|
||
| public const TYPE_LABEL = 'label'; | ||
| public const TYPE_DESCRIPTION = 'description'; | ||
| public const TYPE_ALIAS = 'alias'; |
There was a problem hiding this comment.
Maybe having one for aliases would be good too? Just thinking out loud.
There was a problem hiding this comment.
The scary thing is that some services (e.g. TermBuffer and by association PrefetchingTermLookup and friends) expect to be passed 'alias' not 'aliases' to fetch all aliases. That can probably be solved by documenting it properly, but my original motivation was actually to have these constants to avoid exactly this mix-up.
|
Maybe |
Useful when passing term types to services like TermBuffer.
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when passing term types to services like TermBuffer.