Fix unreliable input on SpellingVariantInput #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the port from Wikit to Codex, the new implementation of `SpellingVariantInput` was working, but was dropping some inputs entered by users. Remove the unused `search-input` attribute of the Codex Lookup component in `SpellingVariantInput` and wire the `input-value` property in the same way it has been connected in the `ItemLookup` implementation. Bug: T379595
mariushoch
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the port from Wikit to Codex, the new implementation of
SpellingVariantInputwas working, but was dropping some inputs entered by users.Remove the unused
search-inputattribute of the Codex Lookup component inSpellingVariantInputand wire theinput-valueproperty in the same way it has been connected in theItemLookupimplementation.Bug: T379595