Move properties before nested selector to resolve deprecation warnings #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SASS has been emitting a deprecation warning because of a coming change in SASS behaviour: https://sass-lang.com/documentation/breaking-changes/mixed-decls/ In `NewLexemeForm.vue` we were using the `&` parent selector before applying additional properties to the `.wbl-snl-form` element. In this specific case, moving the parent selector after the property declarations has no effect on the semantics of the SASS or the generated CSS, and resolves the deprecation warning. Bug: T372250
yerdua
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SASS has been emitting a deprecation warning because of a coming change in SASS behaviour:
https://sass-lang.com/documentation/breaking-changes/mixed-decls/
In
NewLexemeForm.vuewe were using the&parent selector before applying additional properties to the.wbl-snl-formelement.In this specific case, moving the parent selector after the property declarations has no effect on the semantics of the SASS or the generated CSS, and resolves the deprecation warning.
Bug: T372250