Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Material Design Icons to 4.0.0 #60

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Conversation

lyleunderwood
Copy link
Contributor

Closes #59

  • Updates md script to reflect new structure introduced version 4.0.0 of https://github.com/google/material-design-icons
  • Pulls in base style, outlined style, and twotone styles. There are also "round" and "sharp" styles, but I don't really know what those do. Should they also be included?
  • Attempts to be backward-compatible. This adds the ic_ prefix that exists in 3.0.1 but not in 4.0.0 so that many icons are updated in place. I also have not removed any icons that no longer exist. A different strategy would be to do a major version bump and just clear out the md directory and rebuild it entirely.

@lyleunderwood
Copy link
Contributor Author

Also, is this site building stuff from the README still accurate? I can't find a site directory anywhere, and it seems like there's a webpack config?

@wmira wmira merged commit 09aeaf3 into wmira:master Dec 18, 2020
@wmira
Copy link
Owner

wmira commented Dec 18, 2020

I believe this was moved here: https://github.com/wmira/react-icons-kit-site i need to confirm and test this before I publish

@wmira
Copy link
Owner

wmira commented Jul 29, 2021

@lyleunderwood i updated the main site now with latest lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Material Design Icons to 4.0.0
2 participants