Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use setup.cfg #457

Merged
merged 2 commits into from
Jun 20, 2021
Merged

Conversation

henryiii
Copy link
Collaborator

Since this was mentioned in #455 and I happen to have a tool that does 90% of the conversion automatically, here's the setup.cfg conversion. Shouldn't change anything. I left a token setup.py, but it's not even needed anymore even for editable installs on the latest version of pip. You can't remove the file completely though until you have a pyproject.toml file. But once you do, you can remove it if you want.

@henryiii
Copy link
Collaborator Author

PS: I used a one-time run pipx run setup-cfg-format setup.cfg to have a standard setup.cfg style. I usually add that via pre-commit & pre-commit.ci - see https://scikit-hep.org/developer/style.

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cjolowicz cjolowicz merged commit 0ba939a into wntrblm:main Jun 20, 2021
@cjolowicz cjolowicz mentioned this pull request Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants