-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add header from noxfile.py docstring #454 #459
Conversation
This commit adds the functionality for using the `noxfile.py` module docstring as a header description for the `nox -l` option. The module docstring is now an attribute in `Manifest` which is now populated in `discover_manifest` which is in-turn passed to `honor_list_request` which will print the docstring if it is present, and do nothing if it is not present. I've also added two tests which cover these conditions (existent and non-existent module docstring) and added to an existing parametrized test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🎉
Please see the inline comment about handling whitespace in different docstring styles.
By the way, sorry for the commit spam. I tried to be clever and merge in the upstream changes and got myself confused. Still fairly new to this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds the functionality for using the
noxfile.py
moduledocstring as a header description for the
nox -l
option. #454The module docstring is now an attribute in
Manifest
which isnow populated in
discover_manifest
which is in-turn passedto
honor_list_request
which will print the docstring if it ispresent, and do nothing if it is not present.
I've also added two tests which cover these conditions (existent and
non-existent module docstring) and added to an existing
parametrized test.