Posting an ApplicationDidFinishLaunchingNotification when servlet is initialized #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed unnecessary casts * suppressed warning about potential null pointer exception
…vlet has been initialized (Fix for wocommunity#642)
darkv
added a commit
that referenced
this pull request
May 13, 2015
Posting an ApplicationDidFinishLaunchingNotification when servlet is initialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation to fix #642
Sending the notification from the ERXApplication constructor is too early (e.g it happens before the ERMigrations...) Now, this notification will be posted, when the servlet has been initialized.
Instead of patching ERJars erxservletadaptor.jar, I decided to ditch that file and to include the source code of ERXServletAdaptor into the ERExtension framework.