Fix bat colorization and robust config file detection
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the check, when there are no --style/--theme flags (e.g. when they are in the user config file), the `bat` command line was constructed something like this: bat -l sh --style= --theme= --color=always --paging=never <file> This led to the following error and failure to colorize: error: invalid value '' for '--style <components>': Unknown style, '' For more information, try '--help'. Skip adding those flags when they are empty (not detected).
Instead of hard coded path in `$HOME/.config`, ask `bat` for the correct path. This is more robust since `bat` it is platform independent.
suvayu
changed the title
bat colorization and more robust config file detectionbat colorization and robust config file detection
nobu
reviewed
Sep 21, 2024
Changed the commit slightly to allow for the name batcat
Co-authored-by: Nobuyoshi Nakada <nobu.nakada@gmail.com>
|
Instead of bat as the name of the program please use $prog. At least in Ubuntu the program is called batcat |
|
Thanks for reviewing and accepting the PR 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--style/--themeis detectedbat --config-filefor more robustnessAdditional Remarks
re: config file issue: the location of the config file is platform dependent, it can also be set to a custom location by setting an environment variable. So instead of trying to guess, follow upstream recommendation