Set content-length when decompressing #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Asked about Tesla here: elixir-tesla/tesla#598 |
wojtekmach
approved these changes
Jun 23, 2023
|
Thank you! Could you rebase on main and mention this behaviour in docs? |
tanguilp
force-pushed
the
set-content-length-when-decompressing
branch
from
495821f
to
54a8795
Compare
tanguilp
commented
Jun 23, 2023
lib/req/steps.ex
Outdated
Comment on lines
820
to
865
| This step updates the following headers to reflect the changes: | ||
| - `content-legnth` is set to the length of the decompressed body | ||
| - `content-length` is set to the length of the decompressed body |
There was a problem hiding this comment.
We'll have to add that content-encoding is removed, but this will be done in another PR. Hence the list with one item for now
|
I've rebased and updated the doc. Thanks for the review! |
tanguilp
force-pushed
the
set-content-length-when-decompressing
branch
from
0ce7e1e
to
ca5e882
Compare
|
Reopening after fixing conflicts (it was out-of-sync). In the current state, this PR is a prerequisite for #190 but let me know if you wanna merge in a different order (or merge at all). |
|
Thank you! |
|
@tanguilp @wojtekmach do you mind code reviewing elixir-tesla/tesla#606 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decompressing, the
content-lengthis left unchanged. As a consequence, it's no longer matches the body's length, and could confuse other steps or users.This PR automatically sets
content-lengthafter decompression.It could be discussed if it's worth adding it if it wasn't there in the first place. I'd argue it cannot hurt, and proxies routinely do this. Not only it doesn't hurt, but it can help a client know when the response has been fully recieved (should
Reqbe used in a reverse-proxy one day) especially when using multiplexing (Connection: keep-alive).Not sure if we should update the documentation to notice users about these changes.