switch to :retry 2-arity fun, add support for {:delay, milliseconds}
#226
Conversation
lib/req/steps.ex
Outdated
| {request, response_or_exception} | ||
| case retry do | ||
| {:delay, delay} -> | ||
| unless Req.Request.get_option(request, :retry_delay) do |
There was a problem hiding this comment.
lib/req/steps.ex
Outdated
| end | ||
|
|
||
| defp apply_retry(fun, request, response_or_exception) do | ||
| case Function.info(fun, :arity) do |
There was a problem hiding this comment.
I believe Function.info is slow, please use:
fun when is_function(fun, 1) ->
# ...
fun when is_function(fun, 2) ->
# ...
|
Sorry about the conflicts, I tried resolving some but not sure if I didn’t make things worse. |
You removed my tests and on my computer the tests don't pass any more. |
|
It's funny that your CI is passing. EDIT: |
|
If the production code is roughly what you wanted I can take it from here but of course if you’d like to keep going that’s appreciated too. I think I did a merge with GitHub UI so your changes should be recoverable. Sorry about that. |
|
I'm not following you. What should we do now? Should I bring my tests back or? It's not a problem, just tell me what you expect me to do. |
|
I didn’t mean to remove anything it was a botched merge. Sorry for interfering. Please proceed as you see fit and I’ll review it in a couple days. |
No reason to wait. I just commented a single test that you added at the last moment and it all works now. Please merge and then you can work on that test later. |
|
Thank you! |
1 similar comment
|
Thank you! |
As noted here #203 (comment), I made the agreed changes except for the one changing the behavior of the function when it returns
true. That part I left as it was i.e. it will have delay fetched from theretry-afterheader only if the status code is 429. Again, my advice is not to force users to double check their existing code base when switching to the 2-arity function.