Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs for Req.Request.halt/2 #365

Merged
merged 1 commit into from
May 31, 2024
Merged

Improve docs for Req.Request.halt/2 #365

merged 1 commit into from
May 31, 2024

Conversation

whatyouhide
Copy link
Contributor

Tiny docs improvements + specs.

whatyouhide
whatyouhide commented May 31, 2024
View reviewed changes
lib/req/request.ex
## Examples

def circuit_breaker(request) do
Req.Request.prepend_request_steps(request, circuit_breaker: fn request ->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes it much clearer, thoughts?

@wojtekmach wojtekmach merged commit 357f27a into wojtekmach:main May 31, 2024
2 checks passed
@wojtekmach
Copy link
Owner

Good call, thank you!

@whatyouhide whatyouhide deleted the al/docs branch May 31, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whatyouhide @wojtekmach