Add put_path_params_style/2 step #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
reviewed
Jun 19, 2024
lib/req/steps.ex
Outdated
| @@ -71,6 +72,7 @@ defmodule Req.Steps do | |||
| put_base_url: &Req.Steps.put_base_url/1, | |||
| auth: &Req.Steps.auth/1, | |||
| put_params: &Req.Steps.put_params/1, | |||
| put_path_params_style: &Req.Steps.put_path_params_style/1, | |||
There was a problem hiding this comment.
could you merge this into the put_path_params step instead? It's going to be easier to document too, just another option for that step. Finally, I don't think we need to store it in req.private and instead look at req.options when applying params. I prefer to keep as least things as possible in req.private since it's user accessible. wdyt?
There was a problem hiding this comment.
Suresies, incoming
There was a problem hiding this comment.
@wojtekmach done!
wojtekmach
reviewed
Jun 19, 2024
wojtekmach
reviewed
Jun 19, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt. Not sure I’m doing it right with the option + step, but it seems to work 🙃