pdfjs black flicker #1279
Closed
pdfjs black flicker #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattL75
commented
Jan 13, 2023
| // Show the canvas on success and on errors | ||
| .then(this.onRenderSuccess) | ||
| .catch(this.onRenderError) | ||
| .finally(this.showCanvas) |
There was a problem hiding this comment.
In our fork we actually implemented the following and can confirm it works. However I noticed it failed a test so I changed it to finally, which I believe should have the same effect barring a little different timing.
.then(this.showCanvas, this.showCanvas)
.then(this.onRenderSuccess)
.catch(this.onRenderError)
|
I am also experiencing this issue so this PR is helpful |
|
This is really helpful. Pages with complex graphics take longer to render and showing black looks bad. |
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
36a36d4 to
e249af6
Compare
wojtekmaj
force-pushed
the
main
branch
4 times, most recently
from
744f655 to
5b90b65
Compare
This comment looks to have been removed (although I can't find the commit for it?), but for anyone who's looking, this is the comment |
4 tasks
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
f5a9fd6 to
9243e45
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
fbeabf1 to
240150a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment in pdfjs viewer code: https://github.com/mozilla/pdf.js/blob/master/web/pdf_page_view.js#L994
We also encountered this issue after adding
alpha: falseto canvas context. On zoom or on load the documents now load in from black (a direct consequence ofalpha: false). The idea here is to hide the canvas until it loads.@wojtekmaj Just gonna leave this PR here. Feel free to close and rewrite according to what you think is best :)