-
-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AnnotationLayer.css and TextLayer.css to be in sync with pdf-js 3.6.172 #1503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes are okay, but see my comments above - unfortunately we can't just copy pdfjs-dist CSS character by character.
Ok @wojtekmaj I'm applying the changes right now. |
Changes done. Did a rebase on top of origin/main |
Did a build in the root folder, and I'm running |
Looks like everything's working. Nice! Thanks! |
@wojtekmaj I updated the steps I did in the PR description to match all the reviews you did. For the future you can refer anyone to this PR to see some "instructions" on how to update styles 🙂 |
Oh that's amazing! Always great to have some proper docs :) |
Update
AnnotationLayer.css
andTextLayer.css
to be in sync withpdf-js@3.6.172
!MOZCENTRAL
wrappers and keep content:root { --react-pdf-annotation-layer: 1;
inAnnotationLayer.css
:root { --react-pdf-text-layer: 1;
inTextLayer.css
TextLayer.css
.textLayer
opacity property.textLayer ::selection
stylesps: For future contributors that reference this PR for updating styles, please check also the resolved comments