argoproj#46 Open side panels if checkbox changed to true.

wokeGit · Oct 11, 2017 · 05a30fc · 05a30fc
1 parent 83063f6
commit 05a30fc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/...ultiple-service-launch-panel/setup-job-notifications/setup-job-notifications.component.ts b/...ultiple-service-launch-panel/setup-job-notifications/setup-job-notifications.component.ts
@@ -155,10 +155,12 @@ export class SetupJobNotificationsComponent implements OnInit {
         this.notificationsList[index].validationMessages.missingRecipients.show = false;
     }
 
-    public argoUsersAndGroupsCheckboxChange(notification) {
+    public argoUsersAndGroupsCheckboxChange(notification, index) {
         notification.isArgoUsersAndGroupsVisible = !notification.isArgoUsersAndGroupsVisible;
         if (!notification.isArgoUsersAndGroupsVisible) {
             notification.rules.whom = notification.rules.whom.filter(recipient => (recipient.indexOf('@slack') !== -1 || recipient.indexOf('@user') !== -1)).sort();
+        } else {
+            this.openUserSelectorPanel(index);
         }
     }
 
@@ -171,10 +173,12 @@ export class SetupJobNotificationsComponent implements OnInit {
         }
     }
 
-    public slackChannelsCheckboxChange(notification) {
+    public slackChannelsCheckboxChange(notification, index) {
         notification.isSlackChannelsVisible = !notification.isSlackChannelsVisible;
         if (!notification.isSlackChannelsVisible) {
             notification.rules.whom = notification.rules.whom.filter(recipient => (recipient.indexOf('@slack') === -1)).sort();
+        } else {
+            this.openSlackChannelPanel(index);
         }
     }
 

diff --git a/...common/multiple-service-launch-panel/setup-job-notifications/setup-job-notifications.html b/...common/multiple-service-launch-panel/setup-job-notifications/setup-job-notifications.html
@@ -43,7 +43,7 @@ <h5>{{ 'Select Recipients:' | uppercase }}</h5>
                                         type="checkbox"
                                         id="users_and_groups_{{ i }}"
                                         [checked]="notification.isArgoUsersAndGroupsVisible"
-                                        (change)="argoUsersAndGroupsCheckboxChange(notification)">
+                                        (change)="argoUsersAndGroupsCheckboxChange(notification, i)">
                                     <span><i class="fa fa-check"></i></span>
                                 </div>
                                 <label for="users_and_groups_{{ i }}">{{ 'Argo Users and Groups' | translate }}</label>
@@ -93,7 +93,7 @@ <h5>{{ 'Select Recipients:' | uppercase }}</h5>
 
                             <div class="notification-row__list-item">
                                 <div class="ax-checkbox">
-                                    <input type="checkbox" id="slack_channels_{{ i }}" [checked]="notification.isSlackChannelsVisible" (change)="slackChannelsCheckboxChange(notification)">
+                                    <input type="checkbox" id="slack_channels_{{ i }}" [checked]="notification.isSlackChannelsVisible" (change)="slackChannelsCheckboxChange(notification, i)">
                                     <span><i class="fa fa-check"></i></span>
                                 </div>
                                 <label for="slack_channels_{{ i }}">{{ 'Slack Channels' | translate }}</label>