Fixes for QSPI driver.

wolfSSL · Sep 3, 2024 · 23c5076 · 23c5076
1 parent 8df8f8e
commit 23c5076
Show file tree

Hide file tree

Showing 4 changed files with 61 additions and 42 deletions.
diff --git a/hal/zynq.c b/hal/zynq.c
@@ -737,7 +737,7 @@ static int qspi_exit_4byte_addr(QspiDev_t* dev)
 void qspi_init(uint32_t cpu_clock, uint32_t flash_freq)
 {
     int ret;
-    uint32_t reg_cfg;
+    uint32_t reg_cfg, reg_isr;
     uint8_t id_low[4];
 #if GQPI_USE_DUAL_PARALLEL == 1
     uint8_t id_hi[4];
@@ -784,17 +784,18 @@ void qspi_init(uint32_t cpu_clock, uint32_t flash_freq)
     GQSPI_SEL = 1;
 
     /* Clear and disable interrupts */
-    reg_cfg = GQSPI_ISR;
+    reg_isr = GQSPI_ISR;
     GQSPI_ISR |= GQSPI_ISR_WR_TO_CLR_MASK; /* Clear poll timeout counter interrupt */
-    QSPIDMA_DST_I_STS = QSPIDMA_DST_I_STS; /* clear all active interrupts */
+    reg_cfg = QSPIDMA_DST_I_STS;
+    QSPIDMA_DST_I_STS = reg_cfg; /* clear all active interrupts */
     QSPIDMA_DST_STS |= QSPIDMA_DST_STS_WTC; /* mark outstanding DMA's done */
     GQSPI_IDR = GQSPI_IXR_ALL_MASK; /* disable interrupts */
     QSPIDMA_DST_I_STS = QSPIDMA_DST_I_STS_ALL_MASK; /* disable interrupts */
     /* Reset FIFOs */
     if (GQSPI_ISR & GQSPI_IXR_RX_FIFO_EMPTY) {
         GQSPI_FIFO_CTRL |= (GQSPI_FIFO_CTRL_RST_TX_FIFO | GQSPI_FIFO_CTRL_RST_RX_FIFO);
     }
-    if (reg_cfg & GQSPI_IXR_RX_FIFO_EMPTY) {
+    if (reg_isr & GQSPI_IXR_RX_FIFO_EMPTY) {
         GQSPI_FIFO_CTRL |= GQSPI_FIFO_CTRL_RST_RX_FIFO;
     }
 
@@ -829,6 +830,7 @@ void qspi_init(uint32_t cpu_clock, uint32_t flash_freq)
     GQSPI_EN = 1; /* Enable Device */
 #endif /* USE_QNX */
     (void)reg_cfg;
+    (void)reg_isr;
 
     /* ------ Flash Read ID (retry) ------ */
     timeout = 0;
@@ -948,46 +950,54 @@ int RAMFUNCTION ext_flash_write(uintptr_t address, const uint8_t *data, int len)
 {
     int ret = 0;
     uint8_t cmd[8]; /* size multiple of uint32_t */
-    uint32_t xferSz, page, pages, idx = 0;
+    uint32_t xferSz, page, pages, idx;
     uintptr_t addr;
 
+#if defined(DEBUG_ZYNQ) && DEBUG_ZYNQ >= 2
+    wolfBoot_printf("Flash Write: Addr 0x%x, Ptr %p, Len %d\n",
+        address, data, len);
+#endif
+
     /* write by page */
     pages = ((len + (FLASH_PAGE_SIZE-1)) / FLASH_PAGE_SIZE);
     for (page = 0; page < pages; page++) {
         ret = qspi_write_enable(&mDev);
-        if (ret == GQSPI_CODE_SUCCESS) {
-            xferSz = len;
-            if (xferSz > FLASH_PAGE_SIZE)
-                xferSz = FLASH_PAGE_SIZE;
-
-            addr = address + (page * FLASH_PAGE_SIZE);
-            if (mDev.stripe) {
-                /* For dual parallel the address divide by 2 */
-                addr /= 2;
-            }
+        if (ret != GQSPI_CODE_SUCCESS) {
+            break;
+        }
+        xferSz = len;
+        if (xferSz > FLASH_PAGE_SIZE)
+            xferSz = FLASH_PAGE_SIZE;
+
+        addr = address + (page * FLASH_PAGE_SIZE);
+        if (mDev.stripe) {
+            /* For dual parallel the address divide by 2 */
+            addr /= 2;
+        }
 
-            /* ------ Write Flash (page at a time) ------ */
-            memset(cmd, 0, sizeof(cmd));
-            cmd[idx++] = PAGE_PROG_CMD;
-        #if GQPI_USE_4BYTE_ADDR == 1
-            cmd[idx++] = ((addr >> 24) & 0xFF);
-        #endif
-            cmd[idx++] = ((addr >> 16) & 0xFF);
-            cmd[idx++] = ((addr >> 8)  & 0xFF);
-            cmd[idx++] = ((addr >> 0)  & 0xFF);
-            ret = qspi_transfer(&mDev, cmd, idx,
-                (const uint8_t*)(data + (page * FLASH_PAGE_SIZE)),
-                xferSz, NULL, 0, 0, GQSPI_GEN_FIFO_MODE_SPI);
-            wolfBoot_printf("Flash Page %d Write: Ret %d\n", page, ret);
-            if (ret != GQSPI_CODE_SUCCESS)
-                break;
+        /* ------ Write Flash (page at a time) ------ */
+        memset(cmd, 0, sizeof(cmd));
+        idx = 0;
+        cmd[idx++] = PAGE_PROG_CMD;
+    #if GQPI_USE_4BYTE_ADDR == 1
+        cmd[idx++] = ((addr >> 24) & 0xFF);
+    #endif
+        cmd[idx++] = ((addr >> 16) & 0xFF);
+        cmd[idx++] = ((addr >> 8)  & 0xFF);
+        cmd[idx++] = ((addr >> 0)  & 0xFF);
+        ret = qspi_transfer(&mDev, cmd, idx,
+            (const uint8_t*)(data + (page * FLASH_PAGE_SIZE)),
+            xferSz, NULL, 0, 0, GQSPI_GEN_FIFO_MODE_SPI);
+        wolfBoot_printf("Flash Page %d Write: Ret %d\n", page, ret);
+        if (ret != GQSPI_CODE_SUCCESS)
+            break;
 
-            ret = qspi_wait_ready(&mDev); /* Wait for not busy */
-            if (ret != GQSPI_CODE_SUCCESS) {
-                break;
-            }
-            qspi_write_disable(&mDev);
+        ret = qspi_wait_ready(&mDev); /* Wait for not busy */
+        if (ret != GQSPI_CODE_SUCCESS) {
+            break;
         }
+        qspi_write_disable(&mDev);
+        len -= xferSz;
     }
 
     return ret;
@@ -1013,6 +1023,11 @@ int RAMFUNCTION ext_flash_read(uintptr_t address, uint8_t *data, int len)
     uint8_t cmd[8]; /* size multiple of uint32_t */
     uint32_t idx = 0;
 
+#if defined(DEBUG_ZYNQ) && DEBUG_ZYNQ >= 2
+    wolfBoot_printf("Flash Read: Addr 0x%x, Ptr %p, Len %d\n",
+        address, data, len);
+#endif
+
     if (mDev.stripe) {
         /* For dual parallel the address divide by 2 */
         address /= 2;
@@ -1044,6 +1059,10 @@ int RAMFUNCTION ext_flash_erase(uintptr_t address, int len)
     uint32_t idx = 0;
     uintptr_t qspiaddr;
 
+#if defined(DEBUG_ZYNQ) && DEBUG_ZYNQ >= 2
+    wolfBoot_printf("Flash Erase: Addr 0x%x, Len %d\n",  address, len);
+#endif
+
     while (len > 0) {
         /* For dual parallel the address divide by 2 */
         qspiaddr = (mDev.stripe) ? address / 2 : address;
@@ -1101,7 +1120,7 @@ static int test_ext_flash(QspiDev_t* dev)
 {
     int ret;
     uint32_t i;
-    uint8_t pageData[FLASH_PAGE_SIZE];
+    uint8_t pageData[FLASH_PAGE_SIZE*4];
 
 #ifndef TEST_FLASH_READONLY
     /* Erase sector */

diff --git a/hal/zynq.h b/hal/zynq.h
@@ -195,9 +195,11 @@
 #endif
 #ifndef FLASH_PAGE_SIZE
     #ifdef ZCU102
-        #define FLASH_PAGE_SIZE 256 /* MT25QU512ABB */
+        /* MT25QU512ABB */
+        #define FLASH_PAGE_SIZE 256
     #else
-        #define FLASH_PAGE_SIZE 512 /* MT25QU01GBBB */
+        /* MT25QU01GBBB */
+        #define FLASH_PAGE_SIZE 512
     #endif
 #endif
 #define FLASH_NUM_SECTORS      (FLASH_DEVICE_SIZE/WOLFBOOT_SECTOR_SIZE)

diff --git a/src/boot_aarch64_translation.S b/src/boot_aarch64_translation.S
@@ -118,7 +118,6 @@ MMUTableL1:
 .endif
 #else
 .set DDR_1_REG, 0
-#warning "There's no DDR_1 in the HW design. MMU translation table marks 32 GB DDR address space as undefined"
 #endif
 
 .set UNDEF_1_REG, 0x20 - DDR_1_REG
@@ -169,7 +168,6 @@ MMUTableL2:
 .endif
 #else
 .set DDR_0_REG, 0
-#warning "There's no DDR_0 in the HW design. MMU translation table marks 2 GB DDR address space as undefined"
 #endif
 
 .set UNDEF_0_REG, 0x400 - DDR_0_REG

diff --git a/src/update_ram.c b/src/update_ram.c
@@ -39,8 +39,8 @@ extern int wolfBoot_get_dts_size(void *dts_addr);
 extern uint32_t kernel_load_addr;
 extern uint32_t dts_load_addr;
 
-#if (defined(EXT_FLASH) && defined(NO_XIP)) || \
-    (defined(EXT_ENCRYPTED) && defined(MMU)) && \
+#if ((defined(EXT_FLASH) && defined(NO_XIP)) || \
+    (defined(EXT_ENCRYPTED) && defined(MMU))) && \
     !defined(WOLFBOOT_NO_RAMBOOT)
     /* Load firmware to RAM on boot (single flash read) */
     #undef  WOLFBOOT_USE_RAMBOOT