Skip to content

Commit

Permalink
Peer review feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
dgarske authored and danielinux committed Jul 5, 2023
1 parent 11f46a5 commit 338f4bc
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions hal/nxp_p1021.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#define ENABLE_MP /* multi-core support */
#define ENABLE_IRQ
/* #define ENABLE_QE_CRC32 */ /* CRC32 check on QE disabled by default */
/* #define ENABLE_ETHERNET */ /* Does not support Ethernet UEC */
#endif

/* Debugging */
Expand Down Expand Up @@ -984,12 +983,6 @@ static int hal_cpld_init(void)
ELBC_ORG_CSCT | ELBC_ORG_XACS | ELBC_ORG_SCY | ELBC_ORG_TRLX |
ELBC_ORG_EHTR | ELBC_ORG_EAD));

#ifdef ENABLE_ETHERNET /* ethernet (uec) setup not required */
/* reset micrel phy for each UEC */
set8(BCSR11, get8(BCSR11) & ~BCSR11_ENET_MICRST);
set8(BCSR11, get8(BCSR11) | BCSR11_ENET_MICRST);
#endif

return 0;
}
#endif
Expand Down Expand Up @@ -1491,7 +1484,7 @@ static void hal_mp_init(void)
#endif /* ENABLE_MP */

#ifdef ENABLE_IRQ
void hal_irq_init(void)
static void hal_irq_init(void)
{
uint32_t reg;

Expand All @@ -1505,7 +1498,7 @@ void hal_irq_init(void)
#endif

#ifdef ENABLE_L2_CACHE
void hal_l2_init(void)
static void hal_l2_init(void)
{
uint32_t reg;

Expand Down

0 comments on commit 338f4bc

Please sign in to comment.