Intel FSP support #327
Merged
Intel FSP support #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
Jul 19, 2023
hal/x86_fsp_qemu.c
Outdated
| static void init_sata(void) | ||
| { | ||
| uint32_t version; | ||
| char rbuf[32]; |
There was a problem hiding this comment.
removed in b1c1ba4 - thank you
hal/x86_fsp_tgl.c
Outdated
| { | ||
| uint32_t sata_bar; | ||
| uint32_t version; | ||
| char rbuf[32]; |
There was a problem hiding this comment.
removed in b1c1ba4 - thank you
include/user_settings.h
Outdated
| #define XTPM_WAIT() delay(1000); | ||
| #define DEBUG_WOLFTPM | ||
| #define WOLFTPM_ADV_IO | ||
| #define WOLFTPM_DEBUG_VERBOSE |
There was a problem hiding this comment.
Don't recommend verbose on by default.
src/x86/hob.c
Outdated
| (uint32_t)(hob->u.resource_descriptor.resource_length >> 32), | ||
| (uint32_t)hob->u.resource_descriptor.resource_length | ||
| ); | ||
| // Handle specific fields for this HOB type |
There was a problem hiding this comment.
Use C style /* */ comments.
There was a problem hiding this comment.
the code was unused, it has been removed
| @@ -1572,3 +1572,87 @@ Flash Allocation: | |||
| ``` | |||
|
|
|||
| Detailed steps can be found at [Readme](../IDE/Renesas/e2studio/RA6M4/Readme.md). | |||
|
|
|||
|
|
|||
| ## Intel x86_64 with Intel FSP support | |||
There was a problem hiding this comment.
Can you include sample boot output?
There was a problem hiding this comment.
working on that: other parts of the documentation need to be updated
dgarske
requested changes
Jul 19, 2023
| "or %2, %%eax\r\n" | ||
| "mov %%eax, %%cr0\r\n" | ||
| "mov %3, %%eax\r\n" | ||
| "ljmp %5,$_setcs\r\n" |
There was a problem hiding this comment.
../src/x86/common.c: Assembler messages:
../src/x86/common.c:220: Error: can't handle non absolute segment in `ljmp'
make[1]: *** [Makefile:160: common.o] Error 1```
dgarske
requested changes
Jul 20, 2023
There was a problem hiding this comment.
Still getting:
[CC-x86_64] common.o
gcc -D"__WOLFBOOT" -Werror -Wextra -DARCH_x86_64 -DFORCE_32BIT -DWOLFSSL_SP_DIV_WORD_HALF -DWOLFBOOT_FSP=1 -DWOLFBOOT_TGL=1 -fno-stack-protector -m32 -fno-PIC -fno-pie -mno-mmx -mno-sse -DDEBUG_UART -DUCODE0_ADDRESS=0xfffc4000 -DARCH_FLASH_OFFSET=0x0 -DWOLFBOOT_ORIGIN=0xffff0000 -DBOOTLOADER_PARTITION_SIZE=0x400000 -DWOLFBOOT_ARCH=x86_64 -DTARGET_kontron_vx3060_s2 -D"WOLFBOOT_SIGN_ECC256" -D"FILL_BYTE=0xFF" -O0 -D"DEBUG" -g -ggdb3 -D"WOLFBOOT_HASH_SHA256" -DIMAGE_HEADER_SIZE=256 -DWOLFBOOT_64BIT -DX86_UART_BASE=0xFE032000 -DX86_UART_REG_WIDTH=4 -DX86_UART_MMIO=1 -DPCH_HAS_PCR=1 -DPCI_USE_ECAM=1 -DPCH_PCR_BASE=0xFD000000 -DPCI_ECAM_BASE=0xC0000000 -DFSP_S_UPD_DATA_BASE=0xffe35000 -DWOLFBOOT_LOAD_BASE=0x2000000 -I".." -I"../include/" -I"../lib/wolfssl" -D"WOLFSSL_USER_SETTINGS" -D"WOLFTPM_USER_SETTINGS" -D"PLATFORM_kontron_vx3060_s2" -DBUILD_LOADER_STAGE1 -DWOLFBOOT_STAGE1_SIZE=0x1000 -DWOLFBOOT_STAGE1_LOAD_ADDR= -DWOLFBOOT_STAGE1_FLASH_ADDR= -DWOLFBOOT_STAGE1_BASE_ADDR= -c -o common.o ../src/x86/common.c
../src/x86/common.c: Assembler messages:
../src/x86/common.c:220: Error: can't handle non absolute segment in `ljmp'
make[1]: *** [Makefile:160: common.o] Error 1
davidgarske@P700-XEON:~/GitHub/wolfboot$ which gcc
/usr/bin/gcc
davidgarske@P700-XEON:~/GitHub/wolfboot$ gcc --version
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
dgarske
approved these changes
Jul 24, 2023
|
@rizlik and @danielinux let me know when you are ready for merge. Shall I squash it? |
Signed-off-by: Marco Oliverio <marco@wolfssl.com>
It support basic enumeration (only bus 0), and reading/writing to config space register.
supports querying the ports, detecting the disk and configuring FIS areas. Signed-off-by: Marco Oliverio <marco@wolfssl.com>
support ATA commands to read, write and identify a SATA disk. Signed-off-by: Marco Oliverio <marco@wolfssl.com>
support parsing the table and reading/writing to/from a partition. Signed-off-by: Marco Oliverio <marco@wolfssl.com>
BIOS uses this table to communiate IRQ routing and CPUs number to the OS.
rizlik
force-pushed
the
intel_fsp_support
branch
from
f343eff
to
693c4c0
Compare
|
squashed and tested |
dgarske
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for Intel Architecture using the Intel Firmware Support package.