x86 Stage1: add verification of components #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielinux
force-pushed
the
stage1_verify
branch
from
bd5f098
to
0a56a70
Compare
danielinux
force-pushed
the
stage1_verify
branch
from
6da5215
to
02dfec6
Compare
danielinux
force-pushed
the
stage1_verify
branch
from
325248b
to
7712a38
Compare
|
@rizlik please test on TGL before merging |
rizlik
requested changes
Aug 3, 2023
rizlik
previously approved these changes
Aug 10, 2023
dgarske
requested changes
Aug 10, 2023
| @@ -959,6 +959,10 @@ int wolfBoot_verify_integrity(struct wolfBoot_image *img) | |||
| { | |||
| uint8_t *stored_sha; | |||
| uint16_t stored_sha_len; | |||
| #ifdef STAGE1_AUTH | |||
| /* Override global */ | |||
| uint8_t digest[WOLFBOOT_SHA_DIGEST_SIZE]; | |||
There was a problem hiding this comment.
Isn't there already a global with this name? The comment makes it clear you want to use the local here. Can you think of a better way to do this?
dgarske
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify FSP images + configuration at startup.