Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ccrx use case for rx72n #500

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

miyazakh
Copy link
Contributor

No description provided.

dgarske
dgarske previously approved these changes Sep 3, 2024
@dgarske dgarske assigned danielinux and unassigned wolfSSL-Bot Sep 3, 2024
Copy link
Member

@danielinux danielinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation in user_settings.h for RX72n

@@ -49,6 +49,9 @@
/* #define WOLFBOOT_SIGN_ECC256 */
/* #define WOLFBOOT_SIGN_ECC384 */
/* #define WOLFBOOT_SIGN_ECC521 */
#if !defined(min)
#define min(data1, data2) _builtin_min(data1, data2)
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align "endif" to its "if", replace tab with spaces.

Copy link
Member

@danielinux danielinux Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's a tab in L53 as well, while we use spaces everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. e2Studio inserts tab as default.

@danielinux danielinux merged commit 0367597 into wolfSSL:master Sep 20, 2024
95 checks passed
@miyazakh miyazakh deleted the renesas_rx72n_ccrx branch September 21, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants