Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup #735

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fixup #735

merged 1 commit into from
Aug 16, 2024

Conversation

ejohnstown
Copy link
Contributor

  1. Initialize a local variable DoKexInit() as a compiler complains it is getting used with a garbage value. (Not true, but hushing the compiler.)
  2. In GetInputText() and GetInputData(), set the error value into ssh->error and just return WS_ERROR.

@ejohnstown
Fixup
af66f4a 
1. Initialize a local variable DoKexInit() as a compiler complains it is
   getting used with a garbage value. (Not true, but hushing the
   compiler.)
2. In GetInputText() add braces around the error check if clauses, and
   give the version error its own check instead of a ternary return.
3. In GetInputData(), if the recv return was anything else, return a
   general socket error.
@JacobBarthelmeh JacobBarthelmeh merged commit d57f53b into wolfSSL:master Aug 16, 2024
36 checks passed
@ejohnstown ejohnstown deleted the fixup branch August 16, 2024 22:24
jefferyq2 pushed a commit to jefferyq2/wolfssh that referenced this pull request Sep 24, 2024
@JacobBarthelmeh @jefferyq2
Merge pull request wolfSSL#735 from ejohnstown/fixup
c93b26b 
Fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobBarthelmeh JacobBarthelmeh JacobBarthelmeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejohnstown @JacobBarthelmeh