segfault issue #44
Merged
segfault issue #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
night1rider
force-pushed
the
urllib3-segfaulting-issue
branch
from
4a47118
to
2a19d75
Compare
lealem47
approved these changes
Aug 14, 2023
JacobBarthelmeh
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that in some scenarios that not using ffi.release to free the resources will result in a segfault during the garbage collection stage of python. This issue was specifically found in urllib3 tests when using tlsv13.
Reference: https://cffi.readthedocs.io/en/latest/ref.html#ffi-release-and-the-context-manager