Fixes for minor whitespace and scan tools #4891

dgarske · 2022-02-24T19:57:09Z

src/ssl.c

julek-wolfssl

Thanks for fixing my mistakes! Just a few comments.

src/internal.c

src/ssl.c

…use.

Fixes for multi-test pass. Breaks from PR wolfSSL#4807.

2b794f0

dgarske self-assigned this Feb 24, 2022

dgarske added 2 commits February 24, 2022 12:56

Fix for heap pointer in wolfSSL_DupSession.

6e24e21

Fix for "set but not used".

6dd7a28

dgarske force-pushed the multi_test branch from 6062330 to 6dd7a28 Compare February 24, 2022 21:44

dgarske added 2 commits February 24, 2022 14:09

Fix for IPv6 sockaddr_len set but not read.

c2987a9

Fixes for DoClientTicket changes.

269ab86

dgarske changed the title ~~Fixes for minor whitespace and build errors~~ Fixes for minor whitespace and scan tools Feb 24, 2022

SparkiDev requested changes Feb 25, 2022

View reviewed changes

src/ssl.c Outdated Show resolved Hide resolved

More fixups from cppcheck and clang-tidy.

a39a1c1

dgarske force-pushed the multi_test branch from ae9119d to a39a1c1 Compare February 25, 2022 18:04

julek-wolfssl self-requested a review February 25, 2022 18:12

julek-wolfssl requested changes Feb 25, 2022

View reviewed changes

src/internal.c Show resolved Hide resolved

src/internal.c Show resolved Hide resolved

src/ssl.c Show resolved Hide resolved

dgarske requested review from SparkiDev and julek-wolfssl February 25, 2022 18:58

Peer review fixes. Check idSz and add comment about session variable …

821fd3c

…use.

dgarske force-pushed the multi_test branch from e8fa573 to 821fd3c Compare February 25, 2022 19:38

dgarske assigned SparkiDev and julek-wolfssl and unassigned dgarske Feb 25, 2022

SparkiDev approved these changes Feb 27, 2022

View reviewed changes

dgarske unassigned SparkiDev Feb 28, 2022

julek-wolfssl approved these changes Feb 28, 2022

View reviewed changes

julek-wolfssl merged commit 92bd5a4 into wolfSSL:master Feb 28, 2022

dgarske deleted the multi_test branch March 9, 2022 20:02

Provide feedback