Misc. fixes #5169
Merged
Misc. fixes #5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
May 24, 2022
wolfssl/wolfcrypt/types.h
Outdated
| @@ -828,7 +828,7 @@ decouple library dependencies with standard string, memory and so on. | |||
| #endif | |||
|
|
|||
| #ifndef OFFSETOF | |||
| #if defined(__clang__) || defined(__GNUC__) | |||
| #if defined(__clang__) || (__GNUC__ >= 4) | |||
There was a problem hiding this comment.
This needs to also check if __GNUC__ is defined. Please change to:
#if defined(__clang__) || (defined(__GNUC__) && __GNUC__ >= 4)
…trings (in eg. SECP160R1). Note that this now matches the check in wc_EccPublicKeyDecode.
dgarske
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Zephyr fs.h path. Fixes #5135
Remove MCAPI project's depency on zlib version. Fixes #5017
Only use __builtin_offset on supported GCC versions (4+). Fixes ZD 14195
Increase MAX_ECC_STRING to fix off-by-one error. Fixes #5173
Testing
Confirmed wolfSSL builds successfully.
Checklist