Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for TLS1.3 to 1.2 downgrade #7619

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

lealem47
Copy link
Contributor

@lealem47 lealem47 commented Jun 5, 2024

Description

Fix for TLS1.3 to 1.2 downgrade

Fixes zd#18074

Testing

Reproducer in zd ticket

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@@ -5298,6 +5298,13 @@ int DoTls13ServerHello(WOLFSSL* ssl, const byte* input, word32* inOutIdx,
return ret;
}
#endif /* WOLFSSL_DTLS13 */

#ifndef WOLFSSL_NO_TLS12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SparkiDev please review this change

Copy link
Contributor

@SparkiDev SparkiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do something very similar above when no extensions.

@SparkiDev SparkiDev merged commit 162dffb into wolfSSL:master Jun 5, 2024
109 checks passed
@julek-wolfssl
Copy link
Member

This should be fixed in the if (!IsAtLeastTLSv1_3(ssl->version)) section that follows this. Needs a test.

jefferyq2 pushed a commit to jefferyq2/wolfssl that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants