Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data #204

Open
wants to merge 5 commits into
base: data
Choose a base branch
from
Open

Data #204

wants to merge 5 commits into from

Conversation

JustAnotherMimic
Copy link

Updated EO mob information (English only) to contain all important mechanics for every enemy, Floors 1-99. Additionally updated EO mob vulnerability info for Orthoknight. Will update more EO mob vulns in future PRs.

I am unable to test how the text looks in game, so some additional formatting may be required. If it's possible to have the plugin load data from local sources or test branch (via a config option) I can help test.

@wolfcomp
Copy link
Owner

wolfcomp commented Aug 3, 2024

In order to only use local files, you have to build the plugin from the main branch in Debug mode

@JustAnotherMimic
Copy link
Author

It's failing to find the data.dat file that MonsterDexConsole built. I put it in the same directory as the dev build of the plugin when loading it into Dalamud. I'm clearly missing something but not sure what.

2024-08-03 11:45:15.037 -04:00 [ERR] [DeepDungeonDex] 
System.ArgumentNullException: Value cannot be null. (Parameter 'stream')
   at System.ArgumentNullException.Throw(String paramName)
   at System.ArgumentNullException.ThrowIfNull(Object argument, String paramName)
   at System.IO.Compression.ZipArchive..ctor(Stream stream, ZipArchiveMode mode, Boolean leaveOpen, Encoding entryNameEncoding)
   at System.IO.Compression.ZipArchive..ctor(Stream stream, ZipArchiveMode mode)
   at DeepDungeonDex.Requests.GetDat(String path) in C:\Code\FFXIV Modding\MonsterDex-master\DeepDungeonDex\Requests\File.cs:line 42
   at DeepDungeonDex.Requests.GetFromFile(String path) in C:\Code\FFXIV Modding\MonsterDex-master\DeepDungeonDex\Requests\File.cs:line 14
   at DeepDungeonDex.Requests.Get(String url) in C:\Code\FFXIV Modding\MonsterDex-master\DeepDungeonDex\Requests\Data.cs:line 119
   at DeepDungeonDex.Requests.GetFileList() in C:\Code\FFXIV Modding\MonsterDex-master\DeepDungeonDex\Requests\Data.cs:line 45

@JustAnotherMimic
Copy link
Author

Got it working. Will try out formatting the notes a few different ways now that I can see them in-game. Also might try increasing the default size for the mob info window to see what looks good. Thank you for the help/info on how to load the data locally!

@wolfcomp
Copy link
Owner

wolfcomp commented Aug 4, 2024

Max Size will not change due to font scaling affecting how large said window is

@JustAnotherMimic
Copy link
Author

Tested a few different window/font sizes while modifying the notes more to shorten them. I did increase the MinimumSize of the mob info window a bit:
MinimumSize = new Vector2(300 * _config.WindowSizeScaled, 100).

For these screenshots I just overwrote some POTD data for testing since I don't have an open EO file. Happy with how this is turning out so I'll go back and clean up (format + shorten) the EO notes this week and try it out in my actual EO runs to verify enemy IDs and such are correct.

1
2
3
4

@JustAnotherMimic
Copy link
Author

Tested floors 1-100. All mob information displayed correctly. Vulnerabilities should also be correct. You're welcome to merge if you'd like.

Again again - Thank you for making this plugin.

@wolfcomp
Copy link
Owner

There are certain things in here that would need to be fixed before I can agree with it.

That being the removal of telegraphed and untelegraphed text, as these can be very good indicators of what to be on the lookout for before pulling the mobs.

The other things are not needing the 1) and what not on every mob. Numbering scheme should be only reserved when you know a mob is executing actions in a set pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants