fix(sbom,scan): binary package filtering #945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355
This provides better parity with actual Syft and Grype scans, since "binary" packages owned by the APK package are removed when the
ExcludeBinaryPackagesWithFileOwnershipOverlap
option is enabled.cc: @hectorj2f @cpanato
Re: tests: We'll add integration tests to verify this behavior in another PR that conveniently I'm working on at the moment!
This updates the behavior for both SBOM generation and vulnerability scanning:
wolfictl sbom
Before
After
wolfictl scan
Before
After