Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect plural version in notice (_n() not used) #448

Closed
slaFFik opened this issue Feb 6, 2020 · 0 comments · Fixed by #451
Closed

Incorrect plural version in notice (_n() not used) #448

slaFFik opened this issue Feb 6, 2020 · 0 comments · Fixed by #451
Labels
type: bug The issue is a confirmed bug.
Milestone

Comments

@slaFFik
Copy link
Contributor

slaFFik commented Feb 6, 2020

See \ActionScheduler_ListTable::display_admin_notices() method, it has this part:

'message' => sprintf(
	/* translators: %s: amount of claims */
	__( 'Maximum simultaneous queues already in progress (%s queues). No additional queues will begin processing until the current queues are complete.', 'action-scheduler' ),
	$this->store->get_claim_count()
),

If the number of claims is 1 (and it seems to be a default value) we have an incorrect plural in the site admin area:

Maximum simultaneous queues already in progress (1 queues). No additional queues will begin processing until the current queues are complete.

@rrennick rrennick added the type: bug The issue is a confirmed bug. label Feb 6, 2020
@rrennick rrennick added this to the 3.0.2 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants