Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct translation function for numbered string #451

Merged
merged 1 commit into from
Feb 10, 2020
Merged

use correct translation function for numbered string #451

merged 1 commit into from
Feb 10, 2020

Conversation

rrennick
Copy link
Contributor

@rrennick rrennick commented Feb 7, 2020 •
edited
Loading

Fixes #448

This PR changes the translation function for the queues processing notice from __( to _n(.

@rrennick rrennick added type: bug The issue is a confirmed bug. Status: Needs Review labels Feb 7, 2020
@rrennick rrennick added this to the 3.0.2 milestone Feb 7, 2020
jeffstieler
jeffstieler approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@jeffstieler jeffstieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests well. :shipit:

@rrennick rrennick merged commit 38f8696 into master Feb 10, 2020
@rrennick rrennick deleted the issue_448 branch February 10, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffstieler jeffstieler jeffstieler approved these changes

Assignees
No one assigned
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

Incorrect plural version in notice (_n() not used)
2 participants
@rrennick @jeffstieler